Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GraphQL support #3409

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Update GraphQL support #3409

merged 5 commits into from
Jan 26, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Jan 26, 2024 •
edited
Loading

2.0 Upgrade Guide notes

Update our support matrix for GraphQL

Must be >= 2.2.6

Backported

1.13.x : >= 1.13.21, < 2.0
2.0.x : >= 2.0.28, < 2.1
2.1.x : >= 2.1.11, > 2.2

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Jan 26, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review January 26, 2024 17:19
@TonyCTHsu TonyCTHsu requested review from a team as code owners January 26, 2024 17:19
alai97
alai97 reviewed Jan 26, 2024
View reviewed changes
docs/GettingStarted.md Outdated Show resolved Hide resolved
alai97
alai97 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggestion!

brett0000FF
brett0000FF approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some ideas to help communicate these changes. Let me know if you have any questions 👍

lib/datadog/tracing/contrib/graphql/integration.rb Outdated Show resolved Hide resolved
docs/GettingStarted.md Show resolved Hide resolved
brett0000FF
brett0000FF reviewed Jan 26, 2024
View reviewed changes
docs/Compatibility.md Outdated Show resolved Hide resolved
TonyCTHsu and others added 4 commits January 26, 2024 22:13
@TonyCTHsu @alai97
Update docs/GettingStarted.md
1e5de55 
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
@TonyCTHsu @brett0000FF
Update lib/datadog/tracing/contrib/graphql/integration.rb
735c68c 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@TonyCTHsu @brett0000FF
Update docs/GettingStarted.md
3a8ed42 
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
@TonyCTHsu
Update compatibility
640c864
@TonyCTHsu TonyCTHsu merged commit 6959476 into 2.0 Jan 26, 2024
151 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/graphql-support branch January 26, 2024 21:52
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
This was referenced Apr 12, 2024
Closed
Closed
Merged
Merged
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brett0000FF brett0000FF brett0000FF approved these changes

@alai97 alai97 alai97 approved these changes

@marcotc marcotc marcotc approved these changes

Assignees
No one assigned
Labels
2.0 integrations Involves tracing integrations tracing
Projects
None yet
Milestone
2.0.0.beta1
Development

Successfully merging this pull request may close these issues.
5 participants
@TonyCTHsu @marcotc @alai97 @brett0000FF @ivoanjo